Some fixes #287
Merged
Some fixes #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The texture_desired_width can be essential when importing many and large fonts, because the default max of 4096 can run out quite quick and will easily cause GL_INVALID_VALUE errors when refreshing the font texture due to the ridiculous resulting texture height. I don't know why it isn't done by default (might be something to look into implementing in the integrations?), but I've found that now setting:
allows me to get the most out of what I can work with. In my case it was 8192, double the default 4096, and allowed me to scale my interface to 4x+ when without it only went up to 1.7x before crashing.