Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main app refactoring #346

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Main app refactoring #346

merged 3 commits into from
Nov 29, 2023

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Nov 29, 2023 •
edited

Just untangling a bit of spaghetti (and hopefully not adding more).

  • Refactor get_inat_metadata() into observation_to_metadata() and iNatDbClient.from_ids()
  • Use API client object attribute on main app instance instead of module-level object
  • Use session object attribute on main app instance for fetching images instead of module-level object
  • Access globally used objects via main app instance instead of passing them individually to controllers

@JWCook JWCook added the enhancement New feature or request label Nov 29, 2023
@JWCook JWCook added this to the v0.8 milestone Nov 29, 2023
@JWCook JWCook merged commit 34b2ba5 into main Nov 29, 2023
3 checks passed
@JWCook JWCook deleted the refactor branch November 29, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JWCook