Improve reliability of facts.hardware.NetworkDevices
#1098
Merged
Commits on May 12, 2024
-
facts/NetworkDevices: Fix network device name handling
Network device names are allowed to contain most characters, except for `:`, `/`, and whitespace. Ref: https://elixir.bootlin.com/linux/v6.8.9/source/net/core/dev.c#L1047
-
facts/NetworkDevices: Fix incorrect MAC address extraction
The previous regex was matching some IPv6 addresses. Adding a mandatory `ether ` prefix solves this. Also fixed the erroneous test cases.
-
facts/NetworkDevices: Improve IP address extraction
Solves the following issues: - `ip`: missing IPv4 address when metric is present - both: missing IPv4 address when broadcast address is not present Additionally: - Regexes now use named groups for clarity - Minor reorganization and some type hints
-
facts/NetworkDevices: Add additional test cases
Based on an Arch Linux machine. Known issue: the current state parsing behavior is rather imprecise and is not consistent between `ip a` and `ifconfig -a`. For example, the `wlp6s0` interface in the `linux_ifconfig_multiple` test case should have a state of `DOWN`, not `UNKNOWN`.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.