Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appimage builder #957

Closed
wants to merge 4 commits into from
Closed

Conversation

v3ss0n
Copy link
Contributor

@v3ss0n v3ss0n commented Feb 20, 2023

  • added appimage building support , it directly pulls from 2.x branch and then compiles into appimage binary.
  • added a build-time dependency for python-appimage
  • run appimage.sh to build pyinfra as AppImage

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #957 (d753320) into 2.x (0651812) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #957   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         124      124           
  Lines        8053     8053           
=======================================
  Hits         7399     7399           
  Misses        654      654           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@v3ss0n
Copy link
Contributor Author

v3ss0n commented Feb 20, 2023

ready to merge.

@v3ss0n v3ss0n mentioned this pull request Feb 24, 2023
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @v3ss0n, apologies for the long delay on reviewing this, I didn't want to rush a decision and life has been extremely busy recently!

Currently I don't think adding this into pyinfra itself is a good idea - it's an additional distribution method for pyinfra. More distribution methods leads to more issues with each and I already have barely enough time to keep things rolling forward.

There is also the pyinfraller binaries work which will provide yet more distribution methods (but not Linux only) which I am unsure about continuing for the same reason.

I think this would currently be better suited in a separate repository dedicated to pyinfra-appimage generation/distribution.

@v3ss0n
Copy link
Contributor Author

v3ss0n commented May 13, 2023

i see , i will help maintain with a seperate repo , do you want to host inside pyinfra organization?

@v3ss0n v3ss0n closed this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants