[Issue #332] Delete certifi runtime hook

This hook is being deleted because it is not required for certifi to function and it introduces inconsistent behavior between frozen/unfrozen code.
pyinstaller · Oct 25, 2021 · abf3dca · abf3dca
1 parent 55e3c85
commit abf3dca
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 19 deletions.
diff --git a/news/335.update.rst b/news/335.update.rst
@@ -0,0 +1 @@
+Removed the ``certifi`` run-time hook because it was not required for ``certifi`` to function in a frozen application. It was sometimes setting the ``SSL_CERT_FILE`` environment variable which causes applications to behave differently when frozen. In particular the ``SSLContext.set_default_verify_paths()`` method loads the certificates from ``certifi`` when the ``SSL_CERT_FILE`` environment variable is set.
diff --git a/src/_pyinstaller_hooks_contrib/hooks/rthooks.dat b/src/_pyinstaller_hooks_contrib/hooks/rthooks.dat
@@ -1,5 +1,4 @@
 {
-    'certifi': ['pyi_rth_certifi.py'],
     'enchant': ['pyi_rth_enchant.py'],
     'osgeo': ['pyi_rth_osgeo.py'],
     'traitlets': ['pyi_rth_traitlets.py'],

diff --git a/src/_pyinstaller_hooks_contrib/hooks/rthooks/pyi_rth_certifi.py b/src/_pyinstaller_hooks_contrib/hooks/rthooks/pyi_rth_certifi.py