Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When importing trimesh packages, it will import a file called units_t… #25

Merged
merged 4 commits into from
Aug 8, 2020

Conversation

warrenbocphet
Copy link
Contributor

…o_inches.json in resources folder. This file goes undetected when using pyinstaller. Adding a hook solved the issue.

This issue is highlighted here: mikedh/trimesh#412

…o_inches.json in resources folder. This file goes undetected when using pyinstaller. Adding a hook solved the issue.

This issue is highlighted here: mikedh/trimesh#412
@warrenbocphet warrenbocphet requested review from a team and Legorooj and removed request for a team August 7, 2020 23:34
Anh Tran added 2 commits August 8, 2020 09:06
…o_inches.json in resources folder. This file goes undetected when using pyinstaller. Adding a hook solved the issue.

This issue is highlighted here: mikedh/trimesh#412

edit: add an end of line for hook-trimesh.py
Copy link
Member

@Legorooj Legorooj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry - link at the bottom of the README.

@Legorooj Legorooj merged commit 3a41555 into pyinstaller:master Aug 8, 2020
@Legorooj
Copy link
Member

Legorooj commented Aug 8, 2020

@vitsensei a few little bits of feedback:

  1. Don't use the master branch for PRs; create another branch (eg trimesh-hook)
  2. Can you please link the Git Identity with your GitHub account? Add the output of git config user.email as a secondary email in your GitHub account.

danyeaw added a commit to danyeaw/pyinstaller-hooks-contrib that referenced this pull request Oct 4, 2020
tinycss2 pyinstaller#25 updated the packaging which removes the need for a hook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants