-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a hook for ffpyplayer #348
Conversation
a633113
to
15c69f3
Compare
ok i'll add new line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though you may want to change the commit message haha.
sorry for that |
hiddenimports = collect_submodules("ffpyplayer") | ||
binaries = [] | ||
# ffpyplayer has an internal variable tells us where the libraries it was using | ||
for bin in eval_statement("import ffpyplayer; print(ffpyplayer.dep_bins)"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think long-term it would make sense to use get_module_attribute
here. At the moment, though, PyInstaller 4.x version of that function returns string-ified value, while 5.x returns native-type version (presumably a list), so explicitly handling both might not be worth the hassle.
96a462e
to
bf4c65c
Compare
src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-ffpyplayer.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I see you've done CI.
https://stackoverflow.com/questions/69884761/ffpyplayer-importerror-dll-load-failed-while-importing-player-the-specified
See here