Add a hook for ffpyplayer #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric15342335
requested review from
a team and
Legorooj
and removed request for
a team
eric15342335
force-pushed
the
master
branch
2 times, most recently
from
a633113
to
15c69f3
Compare
|
ok i'll add new line |
Legorooj
reviewed
Nov 10, 2021
sorry for that |
rokm
reviewed
Nov 10, 2021
| hiddenimports = collect_submodules("ffpyplayer") | ||
| binaries = [] | ||
| # ffpyplayer has an internal variable tells us where the libraries it was using | ||
| for bin in eval_statement("import ffpyplayer; print(ffpyplayer.dep_bins)"): |
There was a problem hiding this comment.
I think long-term it would make sense to use get_module_attribute here. At the moment, though, PyInstaller 4.x version of that function returns string-ified value, while 5.x returns native-type version (presumably a list), so explicitly handling both might not be worth the hassle.
eric15342335
force-pushed
the
master
branch
2 times, most recently
from
96a462e
to
bf4c65c
Compare
rokm
reviewed
Nov 10, 2021
src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-ffpyplayer.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/69884761/ffpyplayer-importerror-dll-load-failed-while-importing-player-the-specified
See here