-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook for pydantic #78
Conversation
The PyPi version of pydantic comes with all its modules compiled as cpython extensions. This prevents pyinstaller from properly discovering the dependant modules, both from the pydantic package itself and from the standard library.
Here are test matrices for before and after. I suspect that the versions that were passing even before the changes are not compiled. Older versions of |
I take it then that you wish to drop support for anything below 1.4? Realistically, I feel that this kind of self-induced mess is for package authors to clear up - not us. |
I don't think there's anything we can actually do about compiled versions below 1.4. If someone absolutely has to use pyinstaller with those old versions, they'll need to install the non-compiled variant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to remember there being a discussion about reading the imports from python extension modules somewhere, but can't remember off the top of my head. Will look into it again when I tackle modulegraph in January.
The PyPi version of
pydantic
comes with all its modules compiled as cpython extensions. This preventspyinstaller
from properly discovering the dependant modules, both from thepydantic
package itself and from the standard library.Fixes pyinstaller/pyinstaller#5359.