Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license #2

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Add license #2

merged 2 commits into from
Apr 15, 2020

Conversation

Legorooj
Copy link
Member

No description provided.

@Legorooj Legorooj added help wanted Extra attention is needed discussion Please add your opinion and rationale @high This is high priority labels Apr 15, 2020
@Legorooj Legorooj requested a review from htgoebel April 15, 2020 07:48
LICENSE Outdated

This software is made available under the terms of the licenses
found in LICENSE.APL.txt or LICENSE.GPL.txt Contributions to the community hooks are made
under the terms of the license that covers that type of hook. (See below)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reword this along these lines:

  • Project is licensed under GPL-2.0-or later. (so this is the primary license)
    Thus this would cover also files which are not hooks ;-)
  • As an exception for this, run-time hooks are licensed under Apache-2.0.

What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For free Software, this file typically is called COPYING. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For free Software, this file typically is called COPYING. WDYT?

https://stackoverflow.com/questions/5678462/should-i-provide-a-license-txt-or-copying-txt-file-in-my-project

It doesn't matter really. I prefer LICENSE; To me that says "These are the license terms with which you can use this code". But let me know if you'd like it changed.

I've reworded the file locally; I'll push the changes in a minute or two.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the main repo we call it "COPYING.txt", so haveing the same name here would be consistent. But as yu said, it actually dies not matter.
I have no strong preference, you decide.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re frst bullet-point: I'd put the GPL first, since this is the default :-)

LICENSE Show resolved Hide resolved
LICENSE.APL.txt Outdated Show resolved Hide resolved
LICENSE.APL.txt Show resolved Hide resolved
LICENSE.APL.txt Show resolved Hide resolved
LICENSE.APL.txt Show resolved Hide resolved
LICENSE.GPL.txt Outdated Show resolved Hide resolved
LICENSE.GPL.txt Outdated Show resolved Hide resolved
@htgoebel htgoebel mentioned this pull request Apr 15, 2020
@Legorooj Legorooj requested a review from htgoebel April 15, 2020 11:23
@Legorooj Legorooj merged commit d02cdeb into master Apr 15, 2020
@Legorooj Legorooj deleted the license branch April 20, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Please add your opinion and rationale help wanted Extra attention is needed @high This is high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants