hooks: add hook for pystray #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric15342335
requested review from
a team and
Legorooj
and removed request for
a team
rokm
reviewed
Aug 7, 2021
True, but having the hook will ensure compatibility with all versions of And as this is a relatively simple package, having a (potentially) redundant |
Mind putting that in a comment in the hook to aid any future cleaups? Other than that - it looks good. |
Co-authored-by: Rok Mandeljc <rok.mandeljc@gmail.com>
bwoodsend
approved these changes
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pystray chooses different backends for different platforms. Note that if this branch get merged then we don't need this.
(This is the same)
CI