Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include markdown metadata to support entry-points #336

Merged
merged 1 commit into from Oct 20, 2021

Conversation

ovidner
Copy link
Contributor

@ovidner ovidner commented Oct 19, 2021

The markdown package uses entry-points to allow short names for built-in extensions, such as extra or toc. The hook has been updated so that the necessary package metadata is included in the build, enabling the same behavior as the unfrozen package.

This would resolve problems like Python-Markdown/markdown#884.

@ovidner ovidner requested review from a team and bwoodsend and removed request for a team October 19, 2021 21:19
Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that you are aware though that other providers of mardown's entry point will still not be collected.

@bwoodsend
Copy link
Member

CI/CD run is here.

@bwoodsend bwoodsend merged commit f4fe5a7 into pyinstaller:master Oct 20, 2021
@bwoodsend
Copy link
Member

Thanks @ovidner!

@ovidner
Copy link
Contributor Author

ovidner commented Oct 20, 2021

I hope that you are aware though that other providers of mardown's entry point will still not be collected.

Ah yes, that's true. I guess that it could be even better to use collect_entry_point("markdown.extensions"), considering that. But for the time being, I think this resolves the biggest issue. At least it's a fix for my own use-case 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants