Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up beta releases in check for pydantic 2.0.0+ #663

Closed
wants to merge 1 commit into from

Conversation

monorimet
Copy link

Some pre-releases of pydantic have versions in the form "2.X.XbX" so update the conditional in the hook to recognize those versions as well.

Some pre-releases of pydantic have versions in the form "2.X.XbX" so update the conditional in the hook to recognize those versions as well.
@rokm
Copy link
Member

rokm commented Nov 11, 2023

Thanks for bringing this to our attention! I see that pydantic >= 2.0.0 indeed fails to match 2.5.0b1.

This is regression introduced by removal of pkg_resources (pyinstaller/pyinstaller#7943). The old pkg_resources based is_module_satisfies matched pre-release versions, while the new is_module_satisfies / check_requirement do not; but they should (by default) because currently all our hooks depend on that behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants