Fix #2492: Crash if extension module has hidden import to ctypes.

Includes regression test.

PyInstaller/depend/analysis.py

@@ -534,9 +534,8 @@ def get_co_using_ctypes(self):
             referers = self.getReferers(node)
             for r in referers:
                 r_ident =  r.identifier
-                r_type = type(node).__name__
                 # Ensure that modulegraph objects has attribute 'code'.
-                if r_type in PURE_PYTHON_MODULE_TYPES:
+                if type(r).__name__ in PURE_PYTHON_MODULE_TYPES:
                     if r_ident == 'ctypes' or r_ident.startswith('ctypes.'):
                         # Skip modules of 'ctypes' package.
                         continue

tests/functional/test_regression.py

@@ -0,0 +1,35 @@
+#-----------------------------------------------------------------------------
+# Copyright (c) 2005-2017, PyInstaller Development Team.
+#
+# Distributed under the terms of the GNU General Public License with exception
+# for distributing bootloader.
+#
+# The full license is in the file COPYING.txt, distributed with this software.
+#-----------------------------------------------------------------------------
+
+
+import pytest
+import py.path
+
+from PyInstaller.depend import analysis
+from PyInstaller.building.build_main import Analysis
+
+def test_issue_2492(monkeypatch, tmpdir):
+    # Crash if an extension module has an hidden import to ctypes (e.g. added
+    # by the hook).
+
+    # Need to set up some values
+    monkeypatch.setattr('PyInstaller.config.CONF',
+                        {'workpath': str(tmpdir),
+                         'spec': str(tmpdir),
+                         'warnfile': str(tmpdir.join('warn.txt')),
+                         'hiddenimports': []})
+    # Speedup: avoid analyzing base_library.zip
+    monkeypatch.setattr(analysis, 'PY3_BASE_MODULES', [])
+
+    script = tmpdir.join('script.py')
+    script.write('import _struct')
+    # create a hook
+    tmpdir.join('hook-_struct.py').write('hiddenimports = ["ctypes"]')
+    a = Analysis([str(script)], hookspath=[str(tmpdir)],
+                 excludes=['encodings', 'pydoc', 'xml', 'distutils'])