-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
archive: fix TOC entry alignment in PKG/CArchive
The archive writers clean-up in #7518 introduced a subtle bug that causes incorrect padding of TOC entries that require no padding; such entries receive padding of the previously-processed entry. This in turn breaks 16-byte alignment of the TOC entries, causing bus error when running executables on platforms with stricter data alignment requirements, for example armhf (32-bit Raspbian OS).
- Loading branch information
Showing
2 changed files
with
9 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Fix regression on platforms with strict data alignment requirements | ||
(such as linux on `armhf`/`armv7`), caused by bug in PKG/CArchive | ||
generation that was introduced during the archive writer code cleanup. | ||
The regression caused executable to terminate with ``Bus error`` on | ||
the affected platforms, such as 32-bit Debian Buster on Raspberry Pi 4. |