Ddepend: Suppress warnings about missing UCRT dependencies on Win 10.

These files do not exist on Windows 10 on purpose (see issue #1566).
pyinstaller · Feb 26, 2019 · 4af90f4 · 4af90f4
1 parent 682a420
commit 4af90f4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/PyInstaller/depend/bindepend.py b/PyInstaller/depend/bindepend.py
@@ -21,8 +21,9 @@
 import collections
 
 from .. import compat
-from ..compat import (is_win, is_unix, is_aix, is_solar, is_cygwin, is_hpux,
-                      is_darwin, is_freebsd, is_venv, base_prefix, PYDYLIB_NAMES)
+from ..compat import (is_win, is_win_10, is_unix, is_aix, is_solar, is_cygwin,
+                      is_hpux, is_darwin, is_freebsd, is_venv, base_prefix,
+                      PYDYLIB_NAMES)
 from . import dylib, utils
 
 from .. import log as logging
@@ -535,7 +536,10 @@ def selectImports(pth, xtrapath=None):
                              lib, os.path.basename(pth), npth)
                 rv.append((lib, npth))
         else:
-            logger.warning("lib not found: %s dependency of %s", lib, pth)
+            # Don't spew out false warnings on win 10 and UCRT (see issue
+            # #1566).
+            if not (is_win_10 and lib.startswith("api-ms-win-crt")):
+                logger.warning("lib not found: %s dependency of %s", lib, pth)
 
     return rv
 

diff --git a/news/1566.core.rst b/news/1566.core.rst
@@ -0,0 +1 @@
+Suppress warnings about missing UCRT dependencies on Win 10.
diff --git a/news/3736.core.rst b/news/3736.core.rst
@@ -0,0 +1 @@
+Suppress warnings about missing UCRT dependencies on Win 10.