-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hooks: sysconfig: Don't collect pyconfig.h and makefile.
As of Python 3.x, the config header and makefile are not longer used. Trying to include them causes build errors in pyenv/venv/equivalents. Applying this fixes 5018, fixes 4775, and closes 1545 (a cleanup issue). On Windows: The pyconfig.h data is hardcoded directly into sysconfig.py. And the makefile does not exist. On Unix: A Python extension module contains all the details. This module is a hidden import since 3.6 but is already marked as such in the hook. The functions to find and parse the files are still left over in sysconfig.py but they are almost fully replaced by functions to get configuration parameters directly. Should a user attempt to invoke the parser in a PyInstaller build, it will now fail. They should instead use get_config_var() which will always work (and is the recommended usage anyway).
- Loading branch information
Showing
4 changed files
with
6 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Update hook for ``sysconfig`` to be compatible with pyenv-virtualenv. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
No longer collect ``pyconfig.h`` and ``makefile`` for :mod:`sysconfig`. Instead | ||
of :func:`~sysconfig.get_config_h_filename` and | ||
:func:`~sysconfig.get_makefile_filename`, you should use | ||
:func:`~sysconfig.get_config_vars` which no longer depends on those files. |