Rename _rmdir to _rmtree and use only where necessary. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you run any buildtests to make sure anything else is not broken? |
|
Sounds good. Are you going to push it? |
…ap/_rmtree calls into assemble
|
Done. Have run buildtests on Windows and OS X 10.7 (can't currently test Linux). |
|
I run tests on 64bit linux and it seems ok. |
|
One user reported speed improvements with these changes. |
matysek
added a commit
that referenced
this pull request
May 15, 2012
…b65b92 Rename _rmdir to _rmtree and use only where necessary.
|
Thanks @matysek, sorry for the delay |
mrmachine
pushed a commit
to ixc/pyinstaller
that referenced
this pull request
Nov 5, 2014
Issue pyinstaller#812: Some changes to support code signing on Mac OS X.
xoviat
pushed a commit
to xoviat/pyinstaller
that referenced
this pull request
Apr 7, 2021
xoviat
pushed a commit
to xoviat/pyinstaller
that referenced
this pull request
Apr 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into two commits.
Second commit: Clean: Remove unused code after _rmtree calls.