Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising CONFIGDIR #1236

Merged
merged 11 commits into from Jun 23, 2015
Merged

Allow customising CONFIGDIR #1236

merged 11 commits into from Jun 23, 2015

Conversation

mplatings
Copy link
Contributor

When building multiple branches of my project simultaneously, PyInstaller simultaneously tries to modify the same files. By specifying different config directories, I can avoid this problem.

When building multiple branches of my project simultaneously, PyInstaller simultaneously tries to modify the same files. By specifying different config directories, I can avoid this problem.
@htgoebel
Copy link
Member

Thanks, Using an environment variable and not a command-line options for this seams to be appropriate to me, because this should be rarely used.

I'm curious, which files are modified simultaneously. The config-dir basically holds the cache.

To complete the pull-request, please document this in all of the man-pages and the manual.

@htgoebel htgoebel added @low state:needs more work This PR needs more work labels Apr 19, 2015
@mplatings
Copy link
Contributor Author

Thanks Hartmut, will this do?

I'm curious, which files are modified simultaneously.
I should have specified "multiple branches on multiple platforms". Hopefully what I added to the manual will make it clear.

@htgoebel htgoebel added the version:develop Related to the current development branch label May 11, 2015
@htgoebel
Copy link
Member

@mplatings Thanks for updating the manuals :-) When reading 9e57cf3, I understood why this is necessary. Thanks for this explanation.
I wonder if we couldn't fix the root cause, e.g by adding the platform to the name of the cache-dir. Would this work? What do you think?

@htgoebel
Copy link
Member

@mplatings Whould #1269 solve your case, too?

@htgoebel htgoebel removed the state:needs more work This PR needs more work label May 14, 2015
@mplatings
Copy link
Contributor Author

@htgoebel We could have the same architecture on Linux & Mac so I don't think #1269 would be sufficient. However, yes I think your suggestion of adding the platform name (and the architecture too) would do the trick, and would be a more elegant solution :)

@codewarrior0
Copy link
Contributor

There might still be some merit to adding PYINSTALLERCONFIGDIR. Sharing a home directory between VMs is kind of unusual, but I can imagine a use-case of building two different branches of a codebase on the same machine using the same python, cpu, arch, system, etc...

@matysek matysek self-assigned this Jun 22, 2015
@@ -78,7 +78,9 @@
pass


if is_win:
if os.environ.get('PYINSTALLERCONFIGDIR'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mplatings I could you use underscores in this variable name like: PYINSTALLER_CONFIG_DIR

@matysek
Copy link
Member

matysek commented Jun 22, 2015

@mplatings Thanks also for updating the manual. We will need this option for running tests in parallel.

@mplatings
Copy link
Contributor Author

@matysek Done.

matysek added a commit that referenced this pull request Jun 23, 2015
Allow customising CONFIGDIR as environment variable.
@matysek matysek merged commit 25d98d4 into pyinstaller:develop Jun 23, 2015
matysek added a commit that referenced this pull request Jun 23, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@medium Python:3 version:develop Related to the current development branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants