Changes to work with python 2.7 built with gcc on AIX platform #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htgoebel
added
area:bootloader
|
Thanks for the updated pull-request. But I'd ask you to amend the commit-message of the last commit. See https://github.com/pyinstaller/pyinstaller/wiki/Development-Commit-Messages for how we like them commit messages :-) Sory for being a nitpicker her, but we need to spot the content of the commit quickly when looking at it in five years time. |
AIX does not have mkdtemp() implemented on the base system. If one uses xlc compiler, one must use the one defined in 'mkdtemp.h'. However, GCC have mkdtemp() implemented and it will cause problem if 'mkdtemp.h' is included. We will check if mkdtemp() is supported by the compiler and decide if 'mkdtemp.h' should be included.
|
Not a problem! I have amended the commit message. Should I close this one and create another pull request? |
|
Tahnsk. This is a great commit message :-) |
There's no need. The pull request is linked to the branch, so it is always updated when you push to the same branch. You can even amend commits and force push if you like. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HAVE_MKDTEMP flag for AIX with GCC compiler