Modulegraph: Warn on syntax error and unicode error. #2430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htgoebel
reviewed
Feb 16, 2017
| @@ -2129,6 +2129,7 @@ def _load_module(self, fqname, fp, pathname, info): | |||
| except SyntaxError: | |||
| co = None | |||
| cls = InvalidSourceModule | |||
| self.msg(2, "load_module: InvalidSourceModule", pathname) | |||
There was a problem hiding this comment.
Hmm, I've just seen that we are using level 2 and "InvalidSourceModule" here while below we are using level 1 and "SyntaxError". Is this intended?
There was a problem hiding this comment.
No. The UnicodeDecode error should be level two.
|
Thanks for this pull-request. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.