Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: modify os.path.* behavior in site-packages. #2454

Closed
wants to merge 1 commit into from
Closed

WIP: modify os.path.* behavior in site-packages. #2454

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2017

This is currently a concept to repair errors such as #2438. Further work may occur if the idea is approved.

@htgoebel
Copy link
Member

I don't think its a good idea adding such magic to PyInstaller. Its against the Zen of Python, esp. "Explicit is better than implicit", "Special cases aren't special enough to break the rules" and "In the face of ambiguity, refuse the temptation to guess".

If we start patching os.listdir, os.isfile, and os.islink, why not os.stat, open() and file()? Wouldn't we need to patch the whole pythonlib to do it right? And then one comes with a C-extension which will fail. So where would this end if we want to make it correctly?

So, to be frank: I will not accept such a patch. Sorry that you already send time on this.

@htgoebel htgoebel closed this Feb 12, 2017
@htgoebel htgoebel self-assigned this Feb 12, 2017
@htgoebel htgoebel added the solution:won't fix Resolved: Maintainers will not fix this. label Feb 12, 2017
@ghost ghost deleted the patch-5 branch February 12, 2017 15:06
@ghost
Copy link
Author

ghost commented Feb 12, 2017

So, to be frank: I will not accept such a patch. Sorry that you already send time on this.

No, it's fine. It's just 13 lines to sample the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution:won't fix Resolved: Maintainers will not fix this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants