Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with applications using Pythonnet package #3574

Merged
merged 1 commit into from Jun 14, 2018

Conversation

ricard33
Copy link
Contributor

Python.net override built-in import function and is too strict on its signature. This change allow import to work with all Python (and python.net) versions.

Python.net override built-in __import__ function and is too strict on its signature. This change allow import to work with all Python (and python.net) versions.
@htgoebel
Copy link
Member

python.net does not accept a positional parameter to be named? Seriously?

This means that python.net does not follow the language definition: The __import__ function signature clearly defines name to be a positional-or-keyword parameter. So I suggest you open a bug-report there, too.

Nevertheless I'm merging this.

@htgoebel htgoebel merged commit 711a5da into pyinstaller:develop Jun 14, 2018
@htgoebel htgoebel self-assigned this Jun 14, 2018
@ricard33 ricard33 deleted the patch-1 branch June 14, 2018 19:19
@ricard33 ricard33 restored the patch-1 branch June 14, 2018 19:40
@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Sep 2, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants