New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with applications using Pythonnet package #3574

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
2 participants
@ricard33
Contributor

ricard33 commented Jun 14, 2018

Python.net override built-in import function and is too strict on its signature. This change allow import to work with all Python (and python.net) versions.

Make it compatible with applications using Pythonnet package
Python.net override built-in __import__ function and is too strict on its signature. This change allow import to work with all Python (and python.net) versions.
@htgoebel

This comment has been minimized.

Member

htgoebel commented Jun 14, 2018

python.net does not accept a positional parameter to be named? Seriously?

This means that python.net does not follow the language definition: The __import__ function signature clearly defines name to be a positional-or-keyword parameter. So I suggest you open a bug-report there, too.

Nevertheless I'm merging this.

@htgoebel htgoebel merged commit 711a5da into pyinstaller:develop Jun 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@htgoebel htgoebel self-assigned this Jun 14, 2018

@ricard33 ricard33 deleted the ricard33:patch-1 branch Jun 14, 2018

@ricard33 ricard33 restored the ricard33:patch-1 branch Jun 14, 2018

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment