New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the nltk hook and hook for wavefile #3775
Conversation
tried to fix the travice test failure
…verything is as is it should, but travis gives me error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this pull-request.
Please clean it put so I can merge it. Since this are actually two new hooks, it should end up into two commits. And the commit messages should be like "Hooks: Add hook for ..." - since these are no "fixes" but new hooks. You will also need two news fragments (being part of the respective commit).
Also there are still lint-errors:
Found violations: PyInstaller/hooks/hook-wavefile.py
E501 @ 11:80 - line too long (83 > 79 characters)
# add datas for nltk | ||
datas = collect_data_files('nltk', False) | ||
|
||
# loop through the data directories and add them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pleae be a bit more verbose here. What is the nltk.data.path
? Why is it okay to put all data into a single directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nltk.data.path is an environment variable created by nltk while importing it. I have tested this hook file however, it needs some modification to run without any errors.
I forgot: |
about nltk.data.path, this is my only way of doing this. if you know a better solution, let me know |
I don't use nltk, thus I can not give you any tip. Please add a comment so somebody with no knowledge about nltk can understand what nltk.data.path is and why it is save to put all data into one directory. Please mind cleanup, adding changelog-entries and splitting into two commits. Thanks. |
@brightening-eyes Pinging. Please finish this pull-request so I can merge it. Please also rebase, since there are conflicts. Thanks. |
Stale |
hi,
i was working with some audio filetypes and nltk, and i ran into some problem regarding libsndfile-1.dll
so, i've made this hook for wavefile
also fixed the loader for nltk witch had 2 underscores instead of 1 on its filename