Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with distutils/setuptools #40

Merged
merged 32 commits into from Mar 10, 2013
Merged

Integration with distutils/setuptools #40

merged 32 commits into from Mar 10, 2013

Conversation

matysek
Copy link
Member

@matysek matysek commented Feb 27, 2013

This change set include:

  • finished distutils/setuptools
  • fixed running pyinstaller on Windows from path with foreign characters
  • fix regressions where python library was not bundled on debian/ubuntu
  • recompile linux bootloaders
  • some file reorganization

@matysek
Issue #26: Add test case for importing module with unicode text.
8ca8f70
@matysek
Issue #407: Allow running pyinstaller from paths with foreign charact…
a5dfa54 
…ers.
@matysek
Issue #356: Fix bootloader compilation on osx.
6067ebc
@matysek
Issue #356: Fix getting execfile in bootloader on osx.
fce5124
@matysek
Issue #356: Add helloworld test case for onefile mode.
acd1568
@matysek
Issue #356: Fix multiple slashes in temppath on osx.
b5bd119
@matysek
Issue #304: Move old files to one directory.
d2e7c2b
@matysek
Issue #304: Update file setup.py.
73c62b4
@matysek
Issue #304: Move pyinstaller.py to PyInstaller/__main__.py.
e1c27d4
@matysek
Issue #304: Wrap PyInstaller/__main__.py in pyinstaller.py.
bf5c5ba
@matysek
Issue #304: Fix setup.py install command.
638ca3e
@matysek
Issue #304: Include bootloaders with setup.py install.
be6f419
@matysek
Issue #304: Move cli utils to PyInstaller package hierarchy.
262e2e3
@matysek
Issue #304: Remove execute permission from cliutils.
ef9bfc7
@matysek
Issue #304: Add wrapper scripts for pyinstaller cli utils.
3ad406f
@matysek
Issue #304: Wrap pyinstaller cli utils into run() function.
688911d
@matysek
Issue #304: Install cli utils with setup.py install and create cli sc…
e38b44c 
…ripts for them.
@matysek
Fix: Do not use gcc debug flags to compile bootloader with console ou…
13f9063 
…tput.
@matysek
Issue #304: Fix test runner script.
6789f30
@matysek
Issue #304: Recompile 64bit linux bootloader.
6929dcb
@matysek
Clean: Update changelog.
29455d2
@matysek
Clean: Rename directory buildtests -> tests.
71ea5d2
@matysek
Clean: Recompile Linux-32bit bootloader.
4441ce5
@matysek
Fix: Regression where Python library was not bundled on debian.
5790c05
@matysek
Issue #509: Allow running PyInstaller programatically.
56ae6f6
@matysek
Issue #509: In tests invoke PyInstaller programatically and do config…
03f7e0e 
…ure step only once for all tests.
rasky
rasky reviewed Mar 4, 2013
View reviewed changes
PyInstaller/__main__.py
@@ -0,0 +1,93 @@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this file is called __main__? Why not simply use main.py? There is no __main__ convention I know of.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use just main.

rasky
rasky reviewed Mar 4, 2013
View reviewed changes
utils/build.py

if __name__ == '__main__':
from PyInstaller.cliutils.build import run
run()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's getting too much complicated here. We now have like 4 jumps before getting to the actual code. Can we please simplify all these wrappers?

@matysek
Copy link
Member Author

matysek commented Mar 6, 2013

I fixed the following things based on feedback from this pull request:

  • rename main to just main
  • remove some author names and some classifiers from setup.py
  • split description lines in setup.py
  • and simplified wrapper scripts in ./utils
  • pyinstaller will use GetShortPathName only when HOMEPATH contains unicode characters

I think it should be now ok to merge this request.

Hartmut, I'm not sure how to fix setup.py sdist. Could you please take care of it?

@htgoebel
Copy link
Member

htgoebel commented Mar 6, 2013

Yes, I can do work on sdist after the request is merged.

@matysek
Copy link
Member Author

matysek commented Mar 7, 2013

Could anyone please merge it if there are no other objections?

matysek added a commit that referenced this pull request Mar 10, 2013
@matysek
Merge pull request #40 from matysek/develop
120c898 
Integration with distutils/setuptools
@matysek matysek merged commit 120c898 into pyinstaller:develop Mar 10, 2013
This was referenced Oct 18, 2014
Closed
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matysek @htgoebel @rasky @bjones1