Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop apple traceback #4875

Merged
merged 3 commits into from
May 16, 2020
Merged

Conversation

Legorooj
Copy link
Member

@Legorooj Legorooj commented May 15, 2020

Disable the extra traceback on Apple as a fix.

This is monkey-patch style; this bug needs fixing. However, I doubt it will get fixed in PyInstaller 4.0, and we don't want to release a known bug if possible.

Tempory fix for #4860

@Legorooj Legorooj requested review from htgoebel and bjones1 May 15, 2020 08:50
@Legorooj Legorooj self-assigned this May 15, 2020
@Legorooj Legorooj merged commit bcf7fae into pyinstaller:develop May 16, 2020
@Legorooj Legorooj deleted the drop_apple_traceback branch May 16, 2020 03:24
Legorooj added a commit to Legorooj/pyinstaller that referenced this pull request May 17, 2020
…QtQml tests on macOS

* tests: unskip QtQml tests for macOS.
This reverts commit 6aebb5c.

* bootloader: Don't use the traceback added in pyinstaller#4592 when running on macOS
See pyinstaller#4860.
cool-RR pushed a commit to cool-RR/pyinstaller that referenced this pull request Jun 20, 2020
…QtQml tests on macOS

* tests: unskip QtQml tests for macOS.
This reverts commit 6aebb5c.

* bootloader: Don't use the traceback added in pyinstaller#4592 when running on macOS
See pyinstaller#4860.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant