bootloader: implement full back-to-front scan for embedded archive #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on cleanup from #5457. |
rokm
force-pushed
the
bootloader-cookie-search
branch
from
0460e84
to
4b5e514
Compare
rokm
force-pushed
the
bootloader-cookie-search
branch
2 times, most recently
from
c464076
to
b387868
Compare
…okie Implement full back-to-front file scan for finding the embedded archive's cookie. This saves us from having to make assumptions about the cookie's positon, which both simplifies the search and makes it more robust. Currently, we are searching within fixed-sized search window either from the end of file or from end of file's digital signature (if present; on Windows and macOS only). This breaks when a 3rd party tool appends extra data at the end of executable; for example, with PIE bootloader executable, staticx tool on linux will append extra sections at the end of file, which is perfectly valid behavior, but it breaks our fixed-size search window assumptions. Therefore, full back-to-front search fixes pyinstaller#5330. Another motivation for brute-force search is macOS 11, as we will sooner or later want to support universal2 fat binary bootloaders in addition to single-arch thin ones. Full-file search allows us to do so without having to search for digital signature and in turn parsing the headers of each binary format.
rokm
force-pushed
the
bootloader-cookie-search
branch
from
b387868
to
f09400a
Compare
bwoodsend
approved these changes
Feb 23, 2021
|
@Legorooj Any chance this is going to be released soonish? |
|
@pvanderlinden maybe? I can't give you a date as I don't have release credentials myself. Currently talking to someone who does so I can obtain them. |
|
Thanks @Legorooj . Just asking because I didn't see a release for months and this issue is blocking a contribution to a different project |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement full back-to-front file scan for finding the embedded archive's cookie. This saves us from having to make assumptions
about the cookie's positon, which both simplifies the search and makes it more robust.
Currently, we are searching within fixed-sized search window either from the end of file or from end of file's digital signature (if
present; on Windows and macOS only).
This breaks when a 3rd party tool appends extra data at the end of executable; for example, with PIE bootloader executable,
staticxtool on linux will append extra sections at the end of file, which is perfectly valid behavior, but it breaks our fixed-sizesearch window assumptions. Therefore, full back-to-front search fixes #5330 and JonathonReinhart/staticx#71.
Another motivation for brute-force search is macOS 11, as we will sooner or later want to support universal2 fat binary bootloaders in addition to single-arch thin ones. Full-file search allows us to do so without having to search for digital signature and in turn parsing the headers of each binary format.