Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindepend: Skip/warn unrecognised output from ldconfig (#5540). #5547

Merged
merged 1 commit into from Feb 13, 2021

Conversation

bwoodsend
Copy link
Member

Implements the fix outlined in #5540. Fixes #5540.

ldconfig has started adding additional lines of output such as:

Cache generated by: ldconfig (GNU libc) release release version 2.33

which caused regex parse errors. This particular line is now whitelisted
as skipable. And any future unrecognised patterns will now issue
warnings.

Copy link
Member

@rokm rokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Perhaps the news entry should reference the official glibc repository (https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=dfb3f101c5ef23adf60d389058a2b33e23303d04) instead of the unofficial mirror.

). [skip-ci]

ldconfig has started adding additional lines of output such as:

    Cache generated by: ldconfig (GNU libc) release release version 2.33

which caused regex parse errors. This particular line is now whitelisted
as skipable. And any future unrecognised patterns will now issue
warnings.
@bwoodsend
Copy link
Member Author

Link is updated.

@Legorooj Legorooj merged commit ce61bfc into pyinstaller:develop Feb 13, 2021
gozdal pushed a commit to StarfishStorage/pyinstaller that referenced this pull request Jun 10, 2021
). [skip-ci] (pyinstaller#5547)

ldconfig has started adding additional lines of output such as:

    Cache generated by: ldconfig (GNU libc) release release version 2.33

which caused regex parse errors. This particular line is now whitelisted
as skipable. And any future unrecognised patterns will now issue
warnings.
mattiasa pushed a commit to iconik-io/pyinstaller that referenced this pull request Jun 16, 2021
). [skip-ci] (pyinstaller#5547)

ldconfig has started adding additional lines of output such as:

    Cache generated by: ldconfig (GNU libc) release release version 2.33

which caused regex parse errors. This particular line is now whitelisted
as skipable. And any future unrecognised patterns will now issue
warnings.
@bwoodsend bwoodsend deleted the 5540 branch July 10, 2021 11:26
@bwoodsend bwoodsend mentioned this pull request Jul 10, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to correctly parse ldconfig output
4 participants