building: automatically exclude Qt plugins from upx processing #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was originally leaning towards implementing some sort of mechanism for hooks to specify additional upx exclude patterns. However, after some reflection, content-based file exclusion seems like a better (albeit slower) option. |
UPX is known to "corrupt" Qt plugins (it removes the .qtmetad section and QTMETADATA magic string - see upx/upx#107). Instead of requiring users to manually exclude Qt plugins from UPX processing, do it automatically based on the file analysis, i.e., full back-to-front scan for the QTMETADATA magic string. Fixes pyinstaller#4178.
bwoodsend
approved these changes
Jun 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPX is known to "corrupt" Qt plugins (it removes the
.qtmetadsection andQTMETADATAmagic string - see upx/upx#107).Instead of requiring users to manually exclude Qt plugins from UPX processing, do it automatically based on the file analysis, i.e.,
full back-to-front scan for the
QTMETADATAmagic string.Fixes #4178.