Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: fix pkgutil.iter_modules when paths involve symbolic links #6539

Merged
merged 1 commit into from
Jan 25, 2022

Commits on Jan 24, 2022

  1. hooks: fix pkgutil.iter_modules when paths involve symbolic links

    In our pkgutil.iter_module replacement, we need to fully resolve
    both the sys._MEIPASS and the given search paths, in case either
    contains a symbolic link. Failing to do so leads to path mis-match
    when symbolic links are involved and the given search paths are
    already fully resolved. This may happen on macOS with onefile
    builds if the caller of pkgutil.iter_module fully resolves the
    search path(s) before calling the function (issue pyinstaller#6537).
    
    Add a test that reproduces scenario from pyinstaller#6537.
    rokm committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    8422749 View commit details
    Browse the repository at this point in the history