building: fix TOC.__sub__ operator #6671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the TOC.__sub__ operator implementation with a simpler one that properly keeps track of the filenames. Add a test that involves two subsequent subtractions to demonstrate the bug in the old implementation.
bwoodsend
approved these changes
Mar 12, 2022
bwoodsend
added
the
needs backport
rokm
added
backported
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
TOC.__sub__operator implementation with a simpler one that properly keeps track of the filenames. Add a test thatinvolves two subsequent subtractions to demonstrate the bug in the old implementation.
Fixes #6669.