Fix QtWebEngine with PyQt6 framework builds

[The-Compiler]

With a PyPI-installed PyQt6-WebEngine (i.e., from what I understand, a framework-based install) on macOS, some libraries seem to be missing for the renderer process.

The first issue I got was that QtWebEngineProcess can't find QtOpenGL (which is new in Qt 6 and split from QtGui):

dyld: Library not loaded: @rpath/QtOpenGL.framework/Versions/A/QtOpenGL
  Referenced from: [...]/dist/test/PyQt6/Qt6/lib/QtWebEngineCore.framework/Helpers/QtWebEngineProcess.app/Contents/MacOS/QtWebEngineProcess
  Reason: image not found

Adding QtOpenGL to the libraries being copied in a framework build seems to help.

With that fixed (pip install git+https://github.com/the-compiler/pyinstaller@4d6cf4b), I'm getting a similar error about QtDBus, via QtGui:

dyld: Library not loaded: @rpath/QtDBus.framework/Versions/A/QtDBus
  Referenced from: [...]/dist/test/PyQt6/Qt6/lib/QtGui.framework/Versions/A/QtGui
  Reason: image not found

Why QtGui seems to depend on QtDBus on macOS (!) is beyond me, but whatever, let's add it as well.

With both fixes, only this is remaining:

Init Parameters:
  *  application-name  
  *  browser-subprocess-path [...]/dist/test/PyQt6/Qt6/lib/QtWebEngineCore.framework/Helpers/QtWebEngineProcess.app/Contents/MacOS/QtWebEngineProcess 
  *  [...]

Qt WebEngine resources not found at [...]/dist/test//Users/florian/proj/qutebrowser/qtwetest/dist/test. Trying parent directory...
Qt WebEngine resources not found at [...]/dist/test/PyQt6/Qt6. Trying application directory...
Installed Qt WebEngine locales directory not found at location /Users/florian/proj/qutebrowser/qtwetest/dist/test//Users/florian/proj/qutebrowser/qtwetest/dist/test/qtwebengine_locales. Trying application directory...

which seems to be non-fatal, as it seems to work in the end.

[rokm]

Nice catch! This has gone unnoticed because the tests are passing in spite of the QtWebEngineProcess crashing and leaving an error message window.

[rokm]

Please add a news entry for the PR; then this should be good to go.

[The-Compiler]

Updated! Will take a look if I can make the test more strict.

[The-Compiler]

Test pushed too now. Fails for me locally without the change, and will hopefully pass everywhere on CI.

[The-Compiler]

Rebased to merge 4729a83 and 9b77094 into one commit, with no other changes. Should be ready now.

[rokm]

Aside from the backticks in news fragment, this looks good. Thanks for taking care of the test as well!

[The-Compiler]

Whoops! News fragment fixed now. FWIW over at pytest we set Sphinx' default_role to literal to make single backticks work - but not sure I really like it, because it leads to situations like this (and to somewhat inconsistent usage).

[bwoodsend]

I quite like to set the default Sphinx role to :any:`xxx` so that you can put cross references in docstrings without the raw un-sphinx-ified help text having distracting :func:`...` s all over the place. I didn't fancy touching the default role for PyInstaller because a lot of our docs currently uses single backticks instead of single asterisks for itallics.

[The-Compiler]

@bwoodsend added the merge-on-ci-pass label

FYI, just in case you weren't aware: Since some while, GitHub supports enabling a "Enable auto-merge" button which does this automatically:

• Managing auto-merge for pull requests in your repository - GitHub Docs
• Automatically merging a pull request - GitHub Docs

If you're already aware and there's a reason why this doesn't work out for PyInstaller, ignore me 😅

[bwoodsend]

You know, I can't figure out how to get that feature working at all. I've got the box checked under https://github.com/pyinstaller/pyinstaller/settings#merge-button-settings...

... which I expect to lead to an automerge button appearing somewhere on:

But there's no visible changes at all. Nor can I find anywhere to specify exactly what our merge requirements should be (CI passing and at least one stamp of approval from one of the core devs).

[The-Compiler]

Thanks for the merge! 🎉

I believe those are set up as branch protection rules, under "Branches" in the repository settings: Managing a branch protection rule - GitHub Docs

[bwoodsend]

Ahh got it now. I needed to add a rule to make all changes to develop require a pull request, then everything fell into place from there. Thanks for the help.