analysis: warn about binaries with invalid macOS SDK version #8043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the end of analysis, verify the macOS SDK version reported by binaries to be collected, and warn when the version is lower than 10.9.0 (this includes cases when version is invalid, i.e., 0.0.0). According to https://developer.apple.com/forums/thread/132526, hardened runtime requires at least macOS 10.9.0 SDK, so we should warn users about binaries that are expected to cause problems with codesigning and hardened runtime.
|
This is a follow-up to #7899, and should make it easier to debug issues with hardened run-time. For example, I suppose the issue with old binaries is more likely to occur on |
The test uses dummy binary/extension file, and therefore requires special handling of `osxutils.get_macos_sdk_versiom`, similar to what it already has for `bindepend.get_imports`.
bwoodsend
approved these changes
Oct 26, 2023
bwoodsend
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of analysis, verify the macOS SDK version reported by binaries to be collected, and warn when the version is lower than 10.9.0 (this includes cases when version is invalid, i.e., 0.0.0).
According to https://developer.apple.com/forums/thread/132526, hardened runtime requires at least macOS 10.9.0 SDK, so we should warn users about binaries that are expected to cause problems with codesigning and hardened runtime.