building: fix marshal error during DLL search path extension #8086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly convert all DLL search paths obtained via capture of the `os.add_dll_directory` calls to strings. The `add_dll_directory` might be called with `pathlib.Path` paths, which cannot be marshalled out of the child process in which we import packages and track the search path modifications.
bwoodsend
approved these changes
Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly convert all DLL search paths obtained via capture of the
os.add_dll_directorycalls to strings. Theadd_dll_directorymight be called withpathlib.Pathpaths, which cannot be marshalled out of the child process in which we import packages and track the search path modifications.Fixes #8081.