Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building: osx: explicitly convert BUNDLE version to string #8378

Merged
merged 1 commit into from
Mar 26, 2024

Commits on Mar 26, 2024

  1. building: osx: explicitly convert BUNDLE version to string

    Explicitly convert the value of `version` argument to `BUNDLE` into
    a string, in order to mitigate cases when user accidentally enters
    an integer or a float. The version value ends up being written to
    `Info.plist` as the `CFBundleShortVersionString` entry, and if this
    entry is not of a string type (for example, is an integer), the
    generated .app bundle crashes at start.
    rokm committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    060cd32 View commit details
    Browse the repository at this point in the history