Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building: avoid importing PySimpleGUI prior to binary dep. analysis #8397

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

rokm
Copy link
Member

@rokm rokm commented Apr 9, 2024

Add PySimpleGUI to the list of packages whose import should be explicitly suppressed when importing packages for tracking of dynamic library search path modifications prior to binary dependency analysis.

PySimpleGUI 5.x displays a "first-run" dialog when imported for the first time, which breaks unattended PyInstaller builds (for example, building on CI, where the dialog cannot be closed but will be shown every time due to clean environment).

Closes #8396.

Add `PySimpleGUI` to the list of packages whose import should be
explicitly suppressed when importing packages for tracking of
dynamic library search path modifications prior to binary
dependency analysis.

`PySimpleGUI` 5.x displays a "first-run" dialog when imported
for the first time, which breaks unattended PyInstaller builds
(for example, building on CI, where the dialog cannot be closed
but will be shown every time due to clean environment).
@rokm rokm mentioned this pull request Apr 9, 2024
6 tasks
@rokm rokm merged commit 4f194dc into pyinstaller:develop Apr 10, 2024
18 checks passed
@rokm rokm deleted the suppress-import-of-pysimplegui branch April 10, 2024 19:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck at "Looking for dynamic library"
2 participants