Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml import since only vendor-ized variant has version number suffix #430

Merged
merged 1 commit into from Feb 19, 2017
Merged

Fix yaml import since only vendor-ized variant has version number suffix #430

merged 1 commit into from Feb 19, 2017

Conversation

@omadjoudj
Copy link
Contributor

@omadjoudj omadjoudj commented Feb 18, 2017

Related to #412

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 18, 2017

Codecov Report

Merging #430 into master will increase coverage by 0.08%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #430      +/-   ##
=========================================
+ Coverage   92.71%   92.8%   +0.08%     
=========================================
  Files          21      21              
  Lines        2142    2140       -2     
  Branches      377     376       -1     
=========================================
  Hits         1986    1986              
+ Misses        115     113       -2     
  Partials       41      41
Impacted Files Coverage Δ
invoke/config.py 94.57% <ø> (+0.48%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b1cd1...6249ec6. Read the comment docs.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Feb 19, 2017

Guess none of us tested this particular fallback scenario originally :D Thanks for the catch!

@bitprophet bitprophet merged commit df80dd8 into pyinvoke:master Feb 19, 2017
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 0% of diff hit (target 92.71%)
Details
codecov/project 92.8% (+0.08%) compared to e8b1cd1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
bitprophet added a commit that referenced this pull request Feb 19, 2017
@omadjoudj
Copy link
Contributor Author

@omadjoudj omadjoudj commented Feb 19, 2017

That was me :), I tested on an unclean environment (laziness I guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants