Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup appveyor... maybe #525

Closed
wants to merge 2 commits into from
Closed

Fixup appveyor... maybe #525

wants to merge 2 commits into from

Conversation

rpkilby
Copy link
Contributor

@rpkilby rpkilby commented May 14, 2018

This temporarily disables Appveyor CI by moving the config into the appveyor/ directory.

I would attempt to fix this, but that would require making changes to Invocations. The problem is:

  • invoke's tasks depend on invocations.
  • invocations depends on blessings
  • blessings is not compatible with Windows, and therefore, Appveyor.

@bitprophet
Copy link
Member

bitprophet commented Jun 20, 2018

Lazily not actually looking at appveyor yet...what's the status of this now?

If blessings straight up cannot be imported on Windows, that's one thing; if it's just that its runtime invocation blows up due to that lack of terminal size info (...wonder what we do? probably default to 80x24?) we could try skipping whatever we're doing with it on Windows conditionally.

tl;dr invocations needs to be more widely usable now that it's acting as "invoke's contrib" so I'd like it to be importable on Windows in the least.

@thebjorn
Copy link
Contributor

If all you need is screen size on windows, take a look at the ScreenInfo class here https://github.com/thebjorn/doscmd-screen/blob/master/screen.py The docs for the rest of the module is at (https://doscmd-screen.readthedocs.io/). It's limited but x-platform..

@bitprophet
Copy link
Member

@thebjorn We ourselves handle screen size "well enough" on Windows currently (at least, it doesn't explode!), that's not the issue - the issue is what blessings (which invocations, our "extra stuff" package currently relies upon) does something internally which is not Windows compatible :)

We can't control that so we need to figure out how to guard against the problem one level up.

@rpkilby
Copy link
Contributor Author

rpkilby commented Jun 22, 2018

As far as I can tell, blessings is just used for terminal colors, which could probably be replaced with ansicolors or a similar package.

https://github.com/pyinvoke/invocations/blob/e11e77ed63373f0d95e1813af3967e4a0101c6cb/invocations/packaging/release.py#L82-L94

@bitprophet
Copy link
Member

bitprophet commented Jun 22, 2018

I'd have to doublecheck (I felt like there was at least one other thing blessings was used for in invocations besides ANSI) but yes, that's a possibility too - if blessings' kitchen sink approach is too problematic it might not be worth using long term.

@bitprophet bitprophet deleted the branch pyinvoke:master March 18, 2022 17:54
@bitprophet bitprophet closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants