Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[URGENT] inputlist fails when job is submitted #748

Closed
samwaseda opened this issue Jun 19, 2020 · 6 comments · Fixed by #749
Closed

[URGENT] inputlist fails when job is submitted #748

samwaseda opened this issue Jun 19, 2020 · 6 comments · Fixed by #749
Assignees
Labels
bug Category: Something does not work

Comments

@samwaseda
Copy link
Member

samwaseda commented Jun 19, 2020

These lines

        if group_name:
            with hdf.open(group_name) as hdf_group:
                data = hdf_group["data"]

in inputlist.py fail when the job is submitted to the queueing system

@samwaseda samwaseda added the bug Category: Something does not work label Jun 19, 2020
@samwaseda samwaseda changed the title inputlist fails when job is submitted [URGENT] inputlist fails when job is submitted Jun 19, 2020
@jan-janssen
Copy link
Member

Do we test a non modal sphinx calculation in https://github.com/pyiron/pyiron/blob/master/notebooks/tests_sphinx_sphinx_check_all.ipynb ? Maybe that is something we can add to prevent this in future.

@jan-janssen jan-janssen linked a pull request Jun 19, 2020 that will close this issue
@pmrv
Copy link
Contributor

pmrv commented Jun 20, 2020

Setting job.server.run_mode = 'non_modal' in the sphinx notebook does not reproduce the issue. There are some pyiron warnings but the job finishes successfully and gives normal results. Am looking into it on the cluster right now.

Sorry I didn't catch this yesterday immediately.

@jan-janssen
Copy link
Member

@pmrv it is not your mistake. We have to develop processes to prevent such issues and @samwaseda approved the pull request just like I did.

@pmrv
Copy link
Contributor

pmrv commented Jun 20, 2020

I ran the notebook on the cluster with job.server.queue = 'cm' added to all the jobs and I can't seem to trigger an error, just warnings about default parameters.

@samwaseda Is your error related to the new tests in #750?

@jan-janssen
Copy link
Member

@samwaseda Do you still have the original error message? I updated the source reference https://github.com/pyiron/pyiron/blob/inputlist/pyiron/base/generic/inputlist.py#L536
It seems that the issue is that self.table_name is None but this should also affect non_modal jobs ...

@pmrv
Copy link
Contributor

pmrv commented Jun 20, 2020

I added a commit to the new PR that sets the group_name to the table_name that is set in the SphinxBase.__init__. I'm not sure what the code path on loading jobs from hdf5 is. In case the job init is skipped, that could lead to there being no table_name set. This should be fixed with that commit.

@pmrv pmrv closed this as completed in #749 Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Category: Something does not work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants