New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx tests #750
Sphinx tests #750
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Pull Request Test Coverage Report for Build 5086
💛 - Coveralls |
@samwaseda Can yew close this pull request? I guess @pmrv is working on this issue in #749 |
Actually my intention here was to update the test notebook, since as you might have noticed the current test notebook only runs the jobs and does not check if the output is correct. Right now I'm waiting for @pmrv to finish his stuff to adapt this pull request. So I can't close this one. |
Maybe it makes sense to create a separate pull request for the updated notebook. In addition it would be nice to add an example with reload like #749 (comment)
|
That's what I tried to do. I still don't know how to use git properly.
Yes, I totally agree. As I said, I'm only waiting for @pmrv to finish the stuff right now. But ok, I'll try to figure out how to entirely separate this pull request from @pmrv 's one |
ffb9bab
to
2c76e84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
So the test notebook is done (which means this pull request is done). |
A few tests added