Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx tests #750

Merged
merged 4 commits into from Jun 23, 2020
Merged

Sphinx tests #750

merged 4 commits into from Jun 23, 2020

Conversation

samwaseda
Copy link
Member

A few tests added

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@coveralls
Copy link

coveralls commented Jun 19, 2020

Pull Request Test Coverage Report for Build 5086

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.892%

Totals Coverage Status
Change from base Build 5082: 0.0%
Covered Lines: 12309
Relevant Lines: 21262

💛 - Coveralls

@jan-janssen
Copy link
Member

@samwaseda Can yew close this pull request? I guess @pmrv is working on this issue in #749

@samwaseda
Copy link
Member Author

samwaseda commented Jun 23, 2020

Actually my intention here was to update the test notebook, since as you might have noticed the current test notebook only runs the jobs and does not check if the output is correct. Right now I'm waiting for @pmrv to finish his stuff to adapt this pull request. So I can't close this one.

@jan-janssen
Copy link
Member

Maybe it makes sense to create a separate pull request for the updated notebook. In addition it would be nice to add an example with reload like #749 (comment)

from pyiron import Project
pr = Project('SPX_CHECK_ALL')
job = pr.create_job(pr.job_type.Sphinx, 'nonmodal2')
job.structure = pr.create_structure('Fe', 'bcc', a_Fe)
job.calc_static()
job._create_job_structure()
job_reload = pr.load(job.job_name)
job_reload.run()

@samwaseda
Copy link
Member Author

Maybe it makes sense to create a separate pull request for the updated notebook.

That's what I tried to do. I still don't know how to use git properly.

In addition it would be nice to add an example with reload like #749 (comment)

Yes, I totally agree. As I said, I'm only waiting for @pmrv to finish the stuff right now.

But ok, I'll try to figure out how to entirely separate this pull request from @pmrv 's one

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@samwaseda
Copy link
Member Author

samwaseda commented Jun 23, 2020

So the test notebook is done (which means this pull request is done).

@samwaseda samwaseda merged commit 1ff6ce9 into master Jun 23, 2020
@samwaseda samwaseda deleted the sphinx_tests branch June 23, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants