Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arrays and lists in pr.remove_job() #397

Merged
merged 1 commit into from Sep 9, 2019
Merged

Support arrays and lists in pr.remove_job() #397

merged 1 commit into from Sep 9, 2019

Conversation

jan-janssen
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2721

  • 9 of 17 (52.94%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 57.299%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron/base/project/generic.py 9 17 52.94%
Totals Coverage Status
Change from base Build 2708: -0.002%
Covered Lines: 10421
Relevant Lines: 18187
💛 - Coveralls

sudarsan-surendralal
sudarsan-surendralal approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@sudarsan-surendralal sudarsan-surendralal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen jan-janssen merged commit 1319899 into master Sep 9, 2019
@jan-janssen jan-janssen deleted the remove_job_array branch September 9, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudarsan-surendralal sudarsan-surendralal sudarsan-surendralal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jan-janssen @coveralls @sudarsan-surendralal