Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lammps compatible to old versions #407

Merged
merged 1 commit into from Sep 13, 2019
Merged

lammps compatible to old versions #407

merged 1 commit into from Sep 13, 2019

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Sep 13, 2019 •
edited

Otherwise the Lammps 2017 crashes.

@samwaseda
Copy link
Member

What kind of error message do you get?

@jan-janssen
Copy link
Member Author 

ERROR: Illegal atom_modify command (../atom.cpp:581)
Last command: atom_modify map yes

@samwaseda
Copy link
Member

Hm interesting. I'm okay with not having this line, but I'm very sure that we'll need it at some point.

@jan-janssen jan-janssen merged commit 58a483b into master Sep 13, 2019
@jan-janssen jan-janssen deleted the lammps_old branch September 13, 2019 15:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2856

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 73 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 57.716%
Files with Coverage Reduction New Missed Lines %
pyiron/base/master/parallel.py 73 59.74%
Totals Coverage Status
Change from base Build 2854: -0.004%
Covered Lines: 10685
Relevant Lines: 18513
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwaseda samwaseda Awaiting requested review from samwaseda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jan-janssen @samwaseda @coveralls