Lammps bonds #457
Merged
Lammps bonds #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3413
💛 - Coveralls |
jan-janssen
reviewed
Nov 25, 2019
pyiron/lammps/structure.py
Outdated
| + " \n" | ||
| + "{0} bond types".format(num_bond_types) | ||
| + " \n" | ||
| + "{0} angle types".format(num_angle_types) | ||
| + " \n" | ||
| ) | ||
|
|
||
| # atomtypes = list() |
There was a problem hiding this comment.
If it is commented out, do we need it?
There was a problem hiding this comment.
No we don't. Fixed it here 51714a0
|
Is there any way we can test this functionality? |
# Conflicts: # pyiron/lammps/structure.py
|
Shall I merge this @jan-janssen? |
|
You can merge it, but still it would be nice to have tests for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More functions to enable robust functionality