Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing spin_constraint #923

Merged
merged 1 commit into from Aug 31, 2020
Merged

Fixing spin_constraint #923

merged 1 commit into from Aug 31, 2020

Conversation

sudarsan-surendralal
Copy link
Member

Generalizing fixing the constraint!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5986

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 143 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.007%) to 58.033%
Files with Coverage Reduction New Missed Lines %
pyiron/base/project/generic.py 1 50.54%
pyiron/base/project/path.py 2 80.92%
pyiron/base/job/core.py 46 73.87%
pyiron/base/job/generic.py 94 63.61%
Totals Coverage Status
Change from base Build 5969: -0.007%
Covered Lines: 12531
Relevant Lines: 21593
💛 - Coveralls

jan-janssen
jan-janssen approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - feel free to merge it once the tests passed.

@sudarsan-surendralal sudarsan-surendralal merged commit 45e0a4e into master Aug 31, 2020
@sudarsan-surendralal sudarsan-surendralal deleted the fix_mag_constraint branch August 31, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sudarsan-surendralal @coveralls @jan-janssen