Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomsk Wrapper can't deal with hcp structures #388

Closed
pmrv opened this issue Oct 8, 2021 · 0 comments · Fixed by #390
Closed

Atomsk Wrapper can't deal with hcp structures #388

pmrv opened this issue Oct 8, 2021 · 0 comments · Fixed by #390
Assignees
@pmrv
Labels
bug Something isn't working

Comments

@pmrv
Copy link
Contributor

pmrv commented Oct 8, 2021

Axes orientations are currently checked to be 3x3, but for hexagonal they may also be 4x4. Should be a quick fix, just a reminder for myself.
@pmrv pmrv added the bug Something isn't working label Oct 8, 2021
@pmrv pmrv self-assigned this Oct 8, 2021
@pmrv pmrv linked a pull request Oct 14, 2021 that will close this issue
Allow hcp 4-axes indices as well #390
Merged
@pmrv pmrv closed this as completed in #390 Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmrv pmrv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow hcp 4-axes indices as well pyiron/pyiron_atomistics
1 participant
@pmrv