Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only force skew when tensions are applied #263

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Only force skew when tensions are applied #263

merged 1 commit into from
Jul 13, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Jun 30, 2021

calc_md forced triclinic boxes if non-isotropic pressures were set, like (None, 0, None). This is not necessary (and inconsistent with calc_minimize), so I fixed it. I suppose the if just slipped indentations.

@pmrv pmrv added the bug Something isn't working label Jun 30, 2021
@pmrv pmrv requested a review from samwaseda June 30, 2021 13:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 986437826

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.869%

Totals Coverage Status
Change from base Build 983920110: 0.0%
Covered Lines: 10802
Relevant Lines: 15916

💛 - Coveralls

@pmrv pmrv added the integration Start the notebook integration tests for this PR label Jul 13, 2021
@pmrv pmrv merged commit e3e3a61 into master Jul 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the skew branch July 13, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration Start the notebook integration tests for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants