Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HasStructure to Trajectory #270

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Add HasStructure to Trajectory #270

merged 2 commits into from
Jul 2, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Jul 2, 2021

That would be probably be very useful for #251.

@pmrv pmrv added the enhancement New feature or request label Jul 2, 2021
@coveralls
Copy link

coveralls commented Jul 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 993400298

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0002%) to 67.869%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/job/atomistic.py 3 4 75.0%
Totals Coverage Status
Change from base Build 989699451: -0.0002%
Covered Lines: 10804
Relevant Lines: 15919
💛 - Coveralls

sudarsan-surendralal
sudarsan-surendralal approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@sudarsan-surendralal sudarsan-surendralal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a minor nit!

pyiron_atomistics/atomistics/job/atomistic.py Outdated Show resolved Hide resolved
@pmrv @sudarsan-surendralal
Use consistent default argument for frame
f1f2891 
Co-authored-by: Sudarsan Surendralal <surendralal@mpie.de>
@pmrv pmrv merged commit de9042d into master Jul 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the traj branch July 2, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudarsan-surendralal sudarsan-surendralal sudarsan-surendralal approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmrv @coveralls @sudarsan-surendralal