Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending the units class #271

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Extending the units class #271

merged 2 commits into from
Jul 6, 2021

Conversation

sudarsan-surendralal
Copy link
Member

@sudarsan-surendralal sudarsan-surendralal commented Jul 2, 2021 •
edited
Loading

Proper conversion of more quantities. Also dimensionless quantities are supported here.

Edit: Additionally, now we also ensure that the data type of the quantities are preserved.

@sudarsan-surendralal sudarsan-surendralal added the enhancement New feature or request label Jul 2, 2021
@sudarsan-surendralal sudarsan-surendralal linked an issue Jul 2, 2021 that may be closed by this pull request
Noisy Lammps unit conversion #264
Closed
@coveralls
Copy link

coveralls commented Jul 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 994270120

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 67.874%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/units.py 2 97.14%
Totals Coverage Status
Change from base Build 993685928: 0.006%
Covered Lines: 10811
Relevant Lines: 15928
💛 - Coveralls

@sudarsan-surendralal sudarsan-surendralal changed the title Extending the units to include more labels Extending the units class Jul 2, 2021
liamhuber
liamhuber approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'm excited to not see all those unit warnings ;)

@sudarsan-surendralal sudarsan-surendralal merged commit a5f7a22 into master Jul 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_noisy_units branch July 6, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamhuber liamhuber liamhuber approved these changes

@pmrv pmrv Awaiting requested review from pmrv

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noisy Lammps unit conversion
3 participants
@sudarsan-surendralal @coveralls @liamhuber