Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make normal conjugate gradient available #32

Merged
merged 1 commit into from
Jan 26, 2021
Merged

make normal conjugate gradient available #32

merged 1 commit into from
Jan 26, 2021

Conversation

samwaseda
Copy link
Member

Currently only ricQN is available (which is the new optimiser with the up-to-date CG parameters), but since this feature is not well tested, it's probably safer to offer the conventional CG as well (which is linQN)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 500686398

  • 10 of 13 (76.92%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 64.67%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/sphinx/base.py 10 13 76.92%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/sphinx/base.py 1 81.67%
Totals Coverage Status
Change from base Build 499117394: 0.009%
Covered Lines: 10558
Relevant Lines: 16326

💛 - Coveralls

@samwaseda samwaseda merged commit a47a13b into master Jan 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the spx_cg branch January 26, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants