Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move StructureStorage from pyiron_contrib #327

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Move StructureStorage from pyiron_contrib #327

merged 2 commits into from
Aug 27, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Aug 25, 2021

Simply moves the files from contrib to here.

@pmrv pmrv added the enhancement New feature or request label Aug 25, 2021
@coveralls
Copy link

coveralls commented Aug 25, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1173928743

  • 52 of 68 (76.47%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 68.11%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/structure/structurestorage.py 52 68 76.47%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/structure/has_structure.py 5 85.0%
Totals Coverage Status
Change from base Build 1163488168: 0.07%
Covered Lines: 10980
Relevant Lines: 16121
💛 - Coveralls

@pmrv pmrv mentioned this pull request Aug 25, 2021
Merged
@pmrv
Copy link
Contributor Author

pmrv commented Aug 27, 2021 •
edited
Loading

Broken tests are again related to sphinx, so I'll just ignore it for now.

@pmrv pmrv merged commit bdf2f1a into master Aug 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the struct branch August 27, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmrv @coveralls